Skip to content

Commit f80cf81

Browse files
Jesús de Vicente PeñaWebRTC LUCI CQ
authored andcommitted
Changing the pre echo configuration default.
Bug: webrtc:14205 Change-Id: I17add3bf19c599f170ffe98d0da0a561794591c1 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/309481 Commit-Queue: Jesus de Vicente Pena <[email protected]> Reviewed-by: Per Åhgren <[email protected]> Cr-Commit-Position: refs/heads/main@{#40319}
1 parent ff58aed commit f80cf81

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

modules/audio_processing/aec3/matched_filter.cc

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,14 +109,16 @@ size_t ComputePreEchoLag(
109109
}
110110

111111
webrtc::MatchedFilter::PreEchoConfiguration FetchPreEchoConfiguration() {
112-
float threshold = 0.5f;
113-
int mode = 0;
112+
constexpr float kDefaultThreshold = 0.5f;
113+
constexpr int kDefaultMode = 3;
114+
float threshold = kDefaultThreshold;
115+
int mode = kDefaultMode;
114116
const std::string pre_echo_configuration_field_trial =
115117
webrtc::field_trial::FindFullName("WebRTC-Aec3PreEchoConfiguration");
116118
webrtc::FieldTrialParameter<double> threshold_field_trial_parameter(
117-
/*key=*/"threshold", /*default_value=*/threshold);
119+
/*key=*/"threshold", /*default_value=*/kDefaultThreshold);
118120
webrtc::FieldTrialParameter<int> mode_field_trial_parameter(
119-
/*key=*/"mode", /*default_value=*/mode);
121+
/*key=*/"mode", /*default_value=*/kDefaultMode);
120122
webrtc::ParseFieldTrial(
121123
{&threshold_field_trial_parameter, &mode_field_trial_parameter},
122124
pre_echo_configuration_field_trial);

modules/audio_processing/aec3/matched_filter_unittest.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -584,7 +584,7 @@ TEST(MatchedFilterFieldTrialTest, PreEchoConfigurationTest) {
584584

585585
TEST(MatchedFilterFieldTrialTest, WrongPreEchoConfigurationTest) {
586586
constexpr float kDefaultThreshold = 0.5f;
587-
constexpr int kDefaultMode = 0;
587+
constexpr int kDefaultMode = 3;
588588
float threshold_in = -0.1f;
589589
int mode_in = 5;
590590
rtc::StringBuilder field_trial_name;

0 commit comments

Comments
 (0)