-
Notifications
You must be signed in to change notification settings - Fork 312
Improve instrumented test agent creation #9519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~42171792f2, baseline=1.54.0-SNAPSHOT~f7aa6d2c5e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1067304
Total [baseline] (10.642 s) : 0, 10642313
Agent [candidate] (1.061 s) : 0, 1061321
Total [candidate] (10.743 s) : 0, 10743165
section appsec
Agent [baseline] (1.236 s) : 0, 1235538
Total [baseline] (10.856 s) : 0, 10855727
Agent [candidate] (1.246 s) : 0, 1246250
Total [candidate] (10.988 s) : 0, 10988383
section iast
Agent [baseline] (1.19 s) : 0, 1190431
Total [baseline] (10.955 s) : 0, 10955340
Agent [candidate] (1.192 s) : 0, 1191719
Total [candidate] (10.994 s) : 0, 10994058
section profiling
Agent [baseline] (1.218 s) : 0, 1217709
Total [baseline] (11.052 s) : 0, 11052179
Agent [candidate] (1.207 s) : 0, 1207380
Total [candidate] (10.982 s) : 0, 10982392
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~42171792f2, baseline=1.54.0-SNAPSHOT~f7aa6d2c5e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (736.728 ms) : 0, 736728
BytebuddyAgent [candidate] (732.955 ms) : 0, 732955
GlobalTracer [baseline] (253.698 ms) : 0, 253698
GlobalTracer [candidate] (251.99 ms) : 0, 251990
AppSec [baseline] (30.643 ms) : 0, 30643
AppSec [candidate] (30.449 ms) : 0, 30449
Debugger [baseline] (6.4 ms) : 0, 6400
Debugger [candidate] (6.359 ms) : 0, 6359
Remote Config [baseline] (708.003 µs) : 0, 708
Remote Config [candidate] (683.878 µs) : 0, 684
Telemetry [baseline] (16.47 ms) : 0, 16470
Telemetry [candidate] (16.303 ms) : 0, 16303
section appsec
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (756.178 ms) : 0, 756178
BytebuddyAgent [candidate] (761.776 ms) : 0, 761776
GlobalTracer [baseline] (246.169 ms) : 0, 246169
GlobalTracer [candidate] (248.567 ms) : 0, 248567
IAST [baseline] (23.825 ms) : 0, 23825
IAST [candidate] (24.107 ms) : 0, 24107
AppSec [baseline] (170.814 ms) : 0, 170814
AppSec [candidate] (172.753 ms) : 0, 172753
Debugger [baseline] (6.753 ms) : 0, 6753
Debugger [candidate] (6.94 ms) : 0, 6940
Remote Config [baseline] (632.652 µs) : 0, 633
Remote Config [candidate] (636.652 µs) : 0, 637
Telemetry [baseline] (8.46 ms) : 0, 8460
Telemetry [candidate] (8.7 ms) : 0, 8700
section iast
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (852.585 ms) : 0, 852585
BytebuddyAgent [candidate] (852.545 ms) : 0, 852545
GlobalTracer [baseline] (247.1 ms) : 0, 247100
GlobalTracer [candidate] (247.935 ms) : 0, 247935
IAST [baseline] (28.755 ms) : 0, 28755
IAST [candidate] (28.006 ms) : 0, 28006
AppSec [baseline] (24.793 ms) : 0, 24793
AppSec [candidate] (25.758 ms) : 0, 25758
Debugger [baseline] (6.057 ms) : 0, 6057
Debugger [candidate] (6.104 ms) : 0, 6104
Remote Config [baseline] (594.09 µs) : 0, 594
Remote Config [candidate] (618.612 µs) : 0, 619
Telemetry [baseline] (8.102 ms) : 0, 8102
Telemetry [candidate] (8.23 ms) : 0, 8230
section profiling
crashtracking [baseline] (1.447 ms) : 0, 1447
crashtracking [candidate] (1.427 ms) : 0, 1427
BytebuddyAgent [baseline] (766.858 ms) : 0, 766858
BytebuddyAgent [candidate] (760.597 ms) : 0, 760597
GlobalTracer [baseline] (234.141 ms) : 0, 234141
GlobalTracer [candidate] (232.826 ms) : 0, 232826
AppSec [baseline] (30.538 ms) : 0, 30538
AppSec [candidate] (30.308 ms) : 0, 30308
Debugger [baseline] (9.775 ms) : 0, 9775
Debugger [candidate] (8.103 ms) : 0, 8103
Remote Config [baseline] (753.044 µs) : 0, 753
Remote Config [candidate] (703.522 µs) : 0, 704
Telemetry [baseline] (13.461 ms) : 0, 13461
Telemetry [candidate] (14.849 ms) : 0, 14849
ProfilingAgent [baseline] (109.379 ms) : 0, 109379
ProfilingAgent [candidate] (107.537 ms) : 0, 107537
Profiling [baseline] (110.044 ms) : 0, 110044
Profiling [candidate] (108.193 ms) : 0, 108193
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~42171792f2, baseline=1.54.0-SNAPSHOT~f7aa6d2c5e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.07 s) : 0, 1069829
Total [baseline] (8.714 s) : 0, 8713936
Agent [candidate] (1.085 s) : 0, 1084509
Total [candidate] (8.645 s) : 0, 8645265
section iast
Agent [baseline] (1.188 s) : 0, 1188263
Total [baseline] (9.306 s) : 0, 9305801
Agent [candidate] (1.188 s) : 0, 1188333
Total [candidate] (9.34 s) : 0, 9340467
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~42171792f2, baseline=1.54.0-SNAPSHOT~f7aa6d2c5e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.485 ms) : 0, 1485
BytebuddyAgent [baseline] (738.013 ms) : 0, 738013
BytebuddyAgent [candidate] (749.501 ms) : 0, 749501
GlobalTracer [baseline] (254.566 ms) : 0, 254566
GlobalTracer [candidate] (257.745 ms) : 0, 257745
AppSec [baseline] (30.835 ms) : 0, 30835
AppSec [candidate] (31.376 ms) : 0, 31376
Debugger [baseline] (6.435 ms) : 0, 6435
Debugger [candidate] (6.549 ms) : 0, 6549
Remote Config [baseline] (702.407 µs) : 0, 702
Remote Config [candidate] (717.623 µs) : 0, 718
Telemetry [baseline] (16.674 ms) : 0, 16674
Telemetry [candidate] (15.745 ms) : 0, 15745
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (850.632 ms) : 0, 850632
BytebuddyAgent [candidate] (850.856 ms) : 0, 850856
GlobalTracer [baseline] (247.442 ms) : 0, 247442
GlobalTracer [candidate] (246.072 ms) : 0, 246072
IAST [baseline] (27.454 ms) : 0, 27454
IAST [candidate] (29.723 ms) : 0, 29723
AppSec [baseline] (25.51 ms) : 0, 25510
AppSec [candidate] (24.499 ms) : 0, 24499
Debugger [baseline] (6.03 ms) : 0, 6030
Debugger [candidate] (6.099 ms) : 0, 6099
Remote Config [baseline] (614.583 µs) : 0, 615
Remote Config [candidate] (596.225 µs) : 0, 596
Telemetry [baseline] (8.159 ms) : 0, 8159
Telemetry [candidate] (8.116 ms) : 0, 8116
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 12 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~42171792f2, baseline=1.54.0-SNAPSHOT~f7aa6d2c5e
dateFormat X
axisFormat %s
section baseline
no_agent (36.662 ms) : 36363, 36961
. : milestone, 36662,
appsec (47.619 ms) : 47196, 48043
. : milestone, 47619,
code_origins (46.562 ms) : 46151, 46974
. : milestone, 46562,
iast (43.942 ms) : 43580, 44303
. : milestone, 43942,
profiling (48.923 ms) : 48467, 49380
. : milestone, 48923,
tracing (44.573 ms) : 44200, 44946
. : milestone, 44573,
section candidate
no_agent (37.154 ms) : 36850, 37457
. : milestone, 37154,
appsec (47.812 ms) : 47410, 48215
. : milestone, 47812,
code_origins (46.05 ms) : 45635, 46466
. : milestone, 46050,
iast (42.791 ms) : 42411, 43171
. : milestone, 42791,
profiling (48.329 ms) : 47860, 48797
. : milestone, 48329,
tracing (44.954 ms) : 44573, 45336
. : milestone, 44954,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~42171792f2, baseline=1.54.0-SNAPSHOT~f7aa6d2c5e
dateFormat X
axisFormat %s
section baseline
no_agent (4.314 ms) : 4262, 4367
. : milestone, 4314,
iast (9.411 ms) : 9246, 9576
. : milestone, 9411,
iast_FULL (14.09 ms) : 13808, 14372
. : milestone, 14090,
iast_GLOBAL (10.415 ms) : 10214, 10615
. : milestone, 10415,
profiling (9.076 ms) : 8910, 9241
. : milestone, 9076,
tracing (7.579 ms) : 7472, 7686
. : milestone, 7579,
section candidate
no_agent (4.436 ms) : 4385, 4487
. : milestone, 4436,
iast (9.639 ms) : 9468, 9809
. : milestone, 9639,
iast_FULL (14.114 ms) : 13830, 14397
. : milestone, 14114,
iast_GLOBAL (10.068 ms) : 9892, 10245
. : milestone, 10068,
profiling (8.964 ms) : 8811, 9116
. : milestone, 8964,
tracing (7.529 ms) : 7414, 7644
. : milestone, 7529,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~42171792f2, baseline=1.54.0-SNAPSHOT~f7aa6d2c5e
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.666 ms) : 3451, 3881
. : milestone, 3666,
iast (2.208 ms) : 2145, 2271
. : milestone, 2208,
iast_GLOBAL (2.256 ms) : 2192, 2320
. : milestone, 2256,
profiling (2.496 ms) : 2280, 2711
. : milestone, 2496,
tracing (2.022 ms) : 1973, 2071
. : milestone, 2022,
section candidate
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (3.736 ms) : 3517, 3955
. : milestone, 3736,
iast (2.213 ms) : 2150, 2276
. : milestone, 2213,
iast_GLOBAL (2.26 ms) : 2197, 2324
. : milestone, 2260,
profiling (2.051 ms) : 2001, 2102
. : milestone, 2051,
tracing (2.018 ms) : 1969, 2068
. : milestone, 2018,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~42171792f2, baseline=1.54.0-SNAPSHOT~f7aa6d2c5e
dateFormat X
axisFormat %s
section baseline
no_agent (15.065 s) : 15065000, 15065000
. : milestone, 15065000,
appsec (15.199 s) : 15199000, 15199000
. : milestone, 15199000,
iast (18.901 s) : 18901000, 18901000
. : milestone, 18901000,
iast_GLOBAL (17.584 s) : 17584000, 17584000
. : milestone, 17584000,
profiling (15.496 s) : 15496000, 15496000
. : milestone, 15496000,
tracing (15.048 s) : 15048000, 15048000
. : milestone, 15048000,
section candidate
no_agent (15.102 s) : 15102000, 15102000
. : milestone, 15102000,
appsec (14.976 s) : 14976000, 14976000
. : milestone, 14976000,
iast (18.545 s) : 18545000, 18545000
. : milestone, 18545000,
iast_GLOBAL (17.891 s) : 17891000, 17891000
. : milestone, 17891000,
profiling (15.429 s) : 15429000, 15429000
. : milestone, 15429000,
tracing (15.067 s) : 15067000, 15067000
. : milestone, 15067000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the improvement.
a9ac6b0
to
4217179
Compare
...entation-testing/src/main/java/datadog/trace/agent/test/BootstrapClasspathSetupListener.java
Show resolved
Hide resolved
🎯 Code Coverage 🔗 Commit SHA: 4217179 | Docs | Was this helpful? Give us feedback! |
What Does This Do
This PR is a follow up of #9445
Motivation
Address some of the comments in #9445
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]