Skip to content

Commit f6e94b2

Browse files
authored
add type to requests sent to intake (#9520)
help to discriminate type of content when processing by intake
1 parent fbc6b99 commit f6e94b2

File tree

7 files changed

+23
-1
lines changed

7 files changed

+23
-1
lines changed

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/agent/JsonSnapshotSerializer.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ public static class IntakeRequest {
5454
private final DebuggerIntakeRequestData debugger;
5555
private final String ddsource = "dd_debugger";
5656
private final String message;
57+
private final String type = "snapshot";
5758

5859
private final String ddtags;
5960

@@ -146,6 +147,10 @@ public String getLoggerThreadName() {
146147
public String getProcessTags() {
147148
return processTags;
148149
}
150+
151+
public String getType() {
152+
return type;
153+
}
149154
}
150155

151156
public static class DebuggerIntakeRequestData {

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/agent/ProbeStatus.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ public class ProbeStatus {
2525
@Json(name = "ddsource")
2626
private final String ddSource = "dd_debugger";
2727

28+
private final String type = "diagnostic";
29+
2830
private final String service;
2931
private final String message;
3032
private final long timestamp;
@@ -51,6 +53,10 @@ public String getDdSource() {
5153
return ddSource;
5254
}
5355

56+
public String getType() {
57+
return type;
58+
}
59+
5460
public String getService() {
5561
return service;
5662
}

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/sink/SymbolSink.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ public class SymbolSink {
3636
"{%n"
3737
+ "\"ddsource\": \"dd_debugger\",%n"
3838
+ "\"service\": \"%s\",%n"
39-
+ "\"runtimeId\": \"%s\"%n"
39+
+ "\"runtimeId\": \"%s\",%n"
40+
+ "\"type\": \"symdb\"%n"
4041
+ "}";
4142
static final int MAX_SYMDB_UPLOAD_SIZE = 50 * 1024 * 1024;
4243

dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/sink/ProbeStatusSinkTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,7 @@ private void deserialize(String buffer) throws IOException {
325325
MoshiHelper.createMoshiProbeStatus().adapter(ProbeStatus.class);
326326
ProbeStatus probeStatus = adapter.fromJson(buffer);
327327
assertEquals("dd_debugger", probeStatus.getDdSource());
328+
assertEquals("diagnostic", probeStatus.getType());
328329
assertEquals(SERVICE_NAME, probeStatus.getService());
329330
assertEquals("Error installing probe " + PROBE_ID + ".", probeStatus.getMessage());
330331
assertEquals(PROBE_ID, probeStatus.getDiagnostics().getProbeId());

dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/sink/SymbolSinkTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ public void testSimpleFlush() {
3535
String strEventContent = new String(eventContent.getContent());
3636
assertTrue(strEventContent.contains("\"ddsource\": \"dd_debugger\""));
3737
assertTrue(strEventContent.contains("\"service\": \"service1\""));
38+
assertTrue(strEventContent.contains("\"type\": \"symdb\""));
3839
BatchUploader.MultiPartContent symbolContent = symbolUploaderMock.multiPartContents.get(1);
3940
assertEquals("file", symbolContent.getPartName());
4041
assertEquals("file.json", symbolContent.getFileName());

dd-smoke-tests/debugger-integration-tests/src/test/java/datadog/smoketest/ExceptionDebuggerIntegrationTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,10 @@ void testSimpleSingleFrameException() throws Exception {
5353
execute(appUrl, TRACED_METHOD_NAME, "oops"); // collecting snapshots and sending them
5454
registerTraceListener(this::receiveExceptionReplayTrace);
5555
registerSnapshotListener(this::receiveSnapshot);
56+
registerIntakeRequestListener(
57+
intakeRequest -> {
58+
assertEquals("snapshot", intakeRequest.getType());
59+
});
5660
processRequests(
5761
() -> {
5862
if (snapshotIdTags.isEmpty()) {

dd-smoke-tests/debugger-integration-tests/src/test/java/datadog/smoketest/LogProbesIntegrationTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,10 @@ void testFullMethod() throws Exception {
6868
setCurrentConfiguration(createConfig(probe));
6969
targetProcess = createProcessBuilder(logFilePath, METHOD_NAME, EXPECTED_UPLOADS).start();
7070
AtomicBoolean snapshotReceived = new AtomicBoolean();
71+
registerIntakeRequestListener(
72+
intakeRequest -> {
73+
assertEquals("snapshot", intakeRequest.getType());
74+
});
7175
registerSnapshotListener(
7276
snapshot -> {
7377
assertEquals(PROBE_ID.getId(), snapshot.getProbe().getId());

0 commit comments

Comments
 (0)