Skip to content

Commit c2c16dd

Browse files
committed
existence check when getting member for all gh endpoints
1 parent 9e3379c commit c2c16dd

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

backend/src/serverless/integrations/iterators/githubIterator.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ export default class GithubIterator extends BaseIterator {
9595
const stargazersQuery = new StargazersQuery(this.getRepoByName(repoName), this.accessToken)
9696
result = await stargazersQuery.getSinglePage(page)
9797

98-
result.data = result.data.filter((i) => (i as any).node.login)
98+
result.data = result.data.filter((i) => (i as any).node?.login)
9999
break
100100
}
101101
case 'pulls': {
@@ -106,7 +106,7 @@ export default class GithubIterator extends BaseIterator {
106106
result = await pullRequestsQuery.getSinglePage(page)
107107

108108
// filter out activities without authors (such as bots)
109-
result.data = result.data.filter((i) => (i as any).author.login)
109+
result.data = result.data.filter((i) => (i as any).author?.login)
110110

111111
// add each PR as separate endpoint for comments as form repoName|pull-comments|id
112112
result.data.map((pr) =>
@@ -127,7 +127,7 @@ export default class GithubIterator extends BaseIterator {
127127

128128
result = await pullRequestCommentsQuery.getSinglePage(page)
129129

130-
result.data = result.data.filter((i) => (i as any).author.login)
130+
result.data = result.data.filter((i) => (i as any).author?.login)
131131
break
132132
}
133133
case 'issue-comments': {
@@ -139,15 +139,15 @@ export default class GithubIterator extends BaseIterator {
139139
)
140140
result = await issueCommentsQuery.getSinglePage(page)
141141

142-
result.data = result.data.filter((i) => (i as any).author.login)
142+
result.data = result.data.filter((i) => (i as any).author?.login)
143143
break
144144
}
145145
case 'issues': {
146146
const issuesQuery = new IssuesQuery(this.getRepoByName(repoName), this.accessToken)
147147
result = await issuesQuery.getSinglePage(page)
148148

149149
// filter out activities without authors (such as bots)
150-
result.data = result.data.filter((i) => (i as any).author.login)
150+
result.data = result.data.filter((i) => (i as any).author?.login)
151151

152152
// add each issue as separate endpoint for comments as form repoName|issue-comments|id
153153
result.data.map((issue) =>
@@ -163,7 +163,7 @@ export default class GithubIterator extends BaseIterator {
163163
result = await forksQuery.getSinglePage(page)
164164

165165
// filter out activities without authors (such as bots) -- may not the case for forks, but filter out anyways
166-
result.data = result.data.filter((i) => (i as any).owner.login)
166+
result.data = result.data.filter((i) => (i as any).owner?.login)
167167
break
168168
}
169169

@@ -174,7 +174,7 @@ export default class GithubIterator extends BaseIterator {
174174
)
175175
result = await discussionsQuery.getSinglePage(page)
176176

177-
result.data = result.data.filter((i) => (i as any).author.login)
177+
result.data = result.data.filter((i) => (i as any).author?.login)
178178

179179
for (const discussion of result.data) {
180180
if ((discussion as any).comments.totalCount > 0) {
@@ -195,7 +195,7 @@ export default class GithubIterator extends BaseIterator {
195195
)
196196
result = await discussionCommentsQuery.getSinglePage(page)
197197

198-
result.data = result.data.filter((i) => (i as any).author.login)
198+
result.data = result.data.filter((i) => (i as any).author?.login)
199199
break
200200
}
201201

0 commit comments

Comments
 (0)