Prevent unnecessary displayName updates in data-sink-worker (#1372)

garrrikkotua · web-flow · commit 9a7d6e441e07 · 2023-08-22T17:30:18.000+03:00
diff --git a/services/apps/data_sink_worker/src/service/member.service.ts b/services/apps/data_sink_worker/src/service/member.service.ts
@@ -437,7 +437,9 @@ export default class MemberService extends LoggerBase {
       attributes,
       weakIdentities,
       identities,
-      displayName: member.displayName || dbMember.displayName,
+      // we don't want to update the display name if it's already set
+      // returned value should be undefined here otherwise it will cause an update!
+      displayName: dbMember.displayName ? undefined : member.displayName,
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -437,7 +437,9 @@ export default class MemberService extends LoggerBase {`
`437`	`437`	`attributes,`
`438`	`438`	`weakIdentities,`
`439`	`439`	`identities,`
`440`		`- displayName: member.displayName \|\| dbMember.displayName,`
	`440`	`+ // we don't want to update the display name if it's already set`
	`441`	`+ // returned value should be undefined here otherwise it will cause an update!`
	`442`	`+ displayName: dbMember.displayName ? undefined : member.displayName,`
`441`	`443`	`}`
`442`	`444`	`}`
`443`	`445`	`}`