Skip to content

Commit 51f506b

Browse files
authored
Add undefined checks to GitHub integration (#1045)
1 parent 4018f94 commit 51f506b

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

backend/src/serverless/integrations/services/integrations/githubIntegrationService.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1119,11 +1119,11 @@ export class GithubIntegrationService extends IntegrationServiceBase {
11191119
break
11201120
case GithubPullRequestEvents.REQUEST_REVIEW:
11211121
if (
1122-
record.actor.login &&
1123-
(record.requestedReviewer.login || record.requestedReviewer.members)
1122+
record?.actor?.login &&
1123+
(record?.requestedReviewer?.login || record?.requestedReviewer?.members)
11241124
) {
11251125
// Requested review from single member
1126-
if (record.requestedReviewer.login) {
1126+
if (record?.requestedReviewer?.login) {
11271127
const member = await GithubIntegrationService.parseMember(record.actor, context)
11281128
const objectMember = await GithubIntegrationService.parseMember(
11291129
record.requestedReviewer,
@@ -1158,7 +1158,7 @@ export class GithubIntegrationService extends IntegrationServiceBase {
11581158
isContribution:
11591159
GITHUB_GRID[GithubActivityType.PULL_REQUEST_REVIEW_REQUESTED].isContribution,
11601160
})
1161-
} else if (record.requestedReviewer.members) {
1161+
} else if (record?.requestedReviewer?.members) {
11621162
// review is requested from a team
11631163
const member = await GithubIntegrationService.parseMember(record.actor, context)
11641164

@@ -1235,7 +1235,7 @@ export class GithubIntegrationService extends IntegrationServiceBase {
12351235

12361236
break
12371237
case GithubPullRequestEvents.MERGE:
1238-
if (record.actor.login) {
1238+
if (record?.actor?.login) {
12391239
const member = await GithubIntegrationService.parseMember(record.actor, context)
12401240
out.push({
12411241
username: member.username[PlatformType.GITHUB].username,
@@ -1269,7 +1269,7 @@ export class GithubIntegrationService extends IntegrationServiceBase {
12691269

12701270
break
12711271
case GithubPullRequestEvents.CLOSE:
1272-
if (record.actor.login) {
1272+
if (record?.actor?.login) {
12731273
const member = await GithubIntegrationService.parseMember(record.actor, context)
12741274
out.push({
12751275
username: member.username[PlatformType.GITHUB].username,

0 commit comments

Comments
 (0)