Skip to content

Commit 2af0d74

Browse files
committed
Primary is set before merging (#1754)
(cherry picked from commit a4bac6f)
1 parent 623ae2c commit 2af0d74

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

frontend/src/modules/member/pages/member-merge-suggestions-page.vue

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -209,8 +209,9 @@ const fetch = (page) => {
209209
count.value = res.count;
210210
[membersToMerge.value] = res.rows;
211211
const { members } = membersToMerge.value;
212+
primary.value = 0;
212213
// Set member with maximum identities and activities as primary
213-
if (members.length > 2 && ((members[0].identities.length < members[1].identities.length)
214+
if (members.length >= 2 && ((members[0].identities.length < members[1].identities.length)
214215
|| (members[0].activityCount < members[1].activityCount))) {
215216
primary.value = 1;
216217
}
@@ -248,17 +249,17 @@ const mergeSuggestion = () => {
248249
return;
249250
}
250251
sendingMerge.value = true;
251-
primary.value = 0;
252252
MemberService.merge(
253253
membersToMerge.value.members[primary.value],
254254
membersToMerge.value.members[(primary.value + 1) % 2],
255255
)
256256
.then(() => {
257-
Message.success('Members merged successfuly');
257+
primary.value = 0;
258+
Message.success('Contributors merged successfuly');
258259
fetch();
259260
})
260261
.catch(() => {
261-
Message.error('There was an error merging members');
262+
Message.error('There was an error merging contributors');
262263
})
263264
.finally(() => {
264265
sendingMerge.value = false;

frontend/src/modules/organization/pages/organization-merge-suggestions-page.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,7 @@ const fetch = (page) => {
203203
const { organizations } = organizationsToMerge.value;
204204
// Set organization with maximum identities and activities as primary
205205
const [firstOrganization, secondOrganization] = organizations;
206+
primary.value = 0;
206207
if (firstOrganization && secondOrganization && ((firstOrganization.identities.length < secondOrganization.identities.length)
207208
|| (firstOrganization.activityCount < secondOrganization.activityCount))) {
208209
primary.value = 1;
@@ -241,12 +242,12 @@ const mergeSuggestion = () => {
241242
return;
242243
}
243244
sendingMerge.value = true;
244-
primary.value = 0;
245245
OrganizationService.mergeOrganizations(
246246
organizationsToMerge.value.organizations[primary.value].id,
247247
organizationsToMerge.value.organizations[(primary.value + 1) % 2].id,
248248
)
249249
.then(() => {
250+
primary.value = 0;
250251
Message.success('Organizations merged successfuly');
251252
fetch();
252253
})

0 commit comments

Comments
 (0)