Skip to content

AdvancedCollectionView trimming warning is too broad #723

@sylveon

Description

@sylveon

Describe the bug

Currently, the trimming warning for AdvancedCollectionView is too broad. It triggers for all usages of AdvancedCollectionView, when it concerns only SortDescription.PropertyName.

We should move the warning to the appropriate place, so that trimming-safe usages of ACV do not trigger a warning that needs to be suppressed

Additionally, we could add a generic version of SortDescription with [DynamicallyAccessedMembers] so that the required metadata is preserved.

Steps to reproduce

1. Use `new AdvancedCollectionView(myList)` in a project with trimming enabled
2. Observe warning

Expected behavior

There should not be any warning until the code actually does anything unsafe for trimming.

Screenshots

Image

Code Platform

  • UWP
  • WinAppSDK / WinUI 3
  • Web Assembly (WASM)
  • Android
  • iOS
  • MacOS
  • Linux / GTK

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 10 21H2 (Build 19044)
  • Windows 10 22H2 (Build 19045)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

26100

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Windows 10, version 2104 (Build 20348)
  • Windows 11, version 22H2 (Build 22000)
  • Other (specify)

Other SDK version

26100

Visual Studio Version

Preview

Visual Studio Build Number

17.14.0 Preview 4.0

Device form factor

Desktop

Additional context

No response

Help us help you

Yes, I'd like to be assigned to work on this item.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions