From bacfe1c42ea997abfd387e601a45e123b7234f24 Mon Sep 17 00:00:00 2001 From: ssteinbach Date: Thu, 11 Apr 2024 20:54:34 -0700 Subject: [PATCH 1/5] move up codecov version to python 3.10 * no longer compatible with 3.7 --- .github/workflows/python-package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml index 2c7d93ad94..aeb47c6e64 100644 --- a/.github/workflows/python-package.yml +++ b/.github/workflows/python-package.yml @@ -5,7 +5,7 @@ name: OpenTimelineIO # for configuring which build will be a C++ coverage build / coverage report env: - GH_COV_PY: 3.7 + GH_COV_PY: 3.10 GH_COV_OS: ubuntu-22.04 GH_DEPENDABOT: dependabot From 18ac09ad5d9b169030ff3bf9fde0b1238578ac8b Mon Sep 17 00:00:00 2001 From: ssteinbach Date: Thu, 11 Apr 2024 21:04:44 -0700 Subject: [PATCH 2/5] stringify because yaml --- .github/workflows/python-package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml index aeb47c6e64..7cf110bf8e 100644 --- a/.github/workflows/python-package.yml +++ b/.github/workflows/python-package.yml @@ -5,7 +5,7 @@ name: OpenTimelineIO # for configuring which build will be a C++ coverage build / coverage report env: - GH_COV_PY: 3.10 + GH_COV_PY: "3.10" GH_COV_OS: ubuntu-22.04 GH_DEPENDABOT: dependabot From fdc01bee9035a2deb0ad52eab3e2ebcbc65ce78a Mon Sep 17 00:00:00 2001 From: ssteinbach Date: Thu, 11 Apr 2024 21:27:54 -0700 Subject: [PATCH 3/5] add token reference to codecov action --- .github/workflows/python-package.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml index 7cf110bf8e..ab8b529efd 100644 --- a/.github/workflows/python-package.yml +++ b/.github/workflows/python-package.yml @@ -153,6 +153,7 @@ jobs: if: matrix.python-version == env.GH_COV_PY && matrix.os == env.GH_COV_OS && github.actor != env.GH_DEPENDABOT uses: codecov/codecov-action@v3.1.4 with: + token: ${{ secrets.CODECOV_TOKEN }} flags: py-unittests name: py-opentimelineio-codecov fail_ci_if_error: true From dda50b59ea20ba4a8836be98677c00ffc1a292a7 Mon Sep 17 00:00:00 2001 From: ssteinbach Date: Thu, 11 Apr 2024 21:39:49 -0700 Subject: [PATCH 4/5] fix codecov token name --- .github/workflows/python-package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml index ab8b529efd..abfceb36b6 100644 --- a/.github/workflows/python-package.yml +++ b/.github/workflows/python-package.yml @@ -153,7 +153,7 @@ jobs: if: matrix.python-version == env.GH_COV_PY && matrix.os == env.GH_COV_OS && github.actor != env.GH_DEPENDABOT uses: codecov/codecov-action@v3.1.4 with: - token: ${{ secrets.CODECOV_TOKEN }} + CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} flags: py-unittests name: py-opentimelineio-codecov fail_ci_if_error: true From f4679db0196574a1c23bbe07cb1a945888936d49 Mon Sep 17 00:00:00 2001 From: ssteinbach Date: Thu, 11 Apr 2024 21:46:56 -0700 Subject: [PATCH 5/5] walking forward to v4 of the codecov uploader --- .github/workflows/python-package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml index abfceb36b6..f7b2bf49fd 100644 --- a/.github/workflows/python-package.yml +++ b/.github/workflows/python-package.yml @@ -151,7 +151,7 @@ jobs: run: make lcov - name: Upload coverage to Codecov if: matrix.python-version == env.GH_COV_PY && matrix.os == env.GH_COV_OS && github.actor != env.GH_DEPENDABOT - uses: codecov/codecov-action@v3.1.4 + uses: codecov/codecov-action@v4 with: CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} flags: py-unittests