From 765623f826bfa0ee71c4289788c9dc370520dde2 Mon Sep 17 00:00:00 2001 From: Nick Porcino Date: Thu, 17 Mar 2022 17:01:53 -0700 Subject: [PATCH 1/3] clang notices that constexpr can't be used on a mutating function --- src/opentime/rationalTime.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/opentime/rationalTime.h b/src/opentime/rationalTime.h index 8ec7631e00..568a490491 100644 --- a/src/opentime/rationalTime.h +++ b/src/opentime/rationalTime.h @@ -153,7 +153,7 @@ class RationalTime std::string to_time_string() const; - constexpr RationalTime const& operator+=(RationalTime other) noexcept + inline RationalTime const& operator+=(RationalTime other) noexcept { if (_rate < other._rate) { @@ -167,7 +167,7 @@ class RationalTime return *this; } - constexpr RationalTime const& operator-=(RationalTime other) noexcept + inline RationalTime const& operator-=(RationalTime other) noexcept { if (_rate < other._rate) { From 74d19c592a026ba6604297468ebb13bd06323b73 Mon Sep 17 00:00:00 2001 From: Nick Porcino Date: Fri, 18 Mar 2022 17:28:56 -0700 Subject: [PATCH 2/3] Update src/opentime/rationalTime.h --- src/opentime/rationalTime.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/opentime/rationalTime.h b/src/opentime/rationalTime.h index 568a490491..f3974b0f8f 100644 --- a/src/opentime/rationalTime.h +++ b/src/opentime/rationalTime.h @@ -153,7 +153,7 @@ class RationalTime std::string to_time_string() const; - inline RationalTime const& operator+=(RationalTime other) noexcept + RationalTime const& operator+=(RationalTime other) noexcept { if (_rate < other._rate) { From dbf6d679ab7f045c9225873ea270b5f918e6fa70 Mon Sep 17 00:00:00 2001 From: Nick Porcino Date: Fri, 18 Mar 2022 17:29:29 -0700 Subject: [PATCH 3/3] Update src/opentime/rationalTime.h --- src/opentime/rationalTime.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/opentime/rationalTime.h b/src/opentime/rationalTime.h index f3974b0f8f..ca6f8c4eda 100644 --- a/src/opentime/rationalTime.h +++ b/src/opentime/rationalTime.h @@ -167,7 +167,7 @@ class RationalTime return *this; } - inline RationalTime const& operator-=(RationalTime other) noexcept + RationalTime const& operator-=(RationalTime other) noexcept { if (_rate < other._rate) {