Skip to content

Commit e6e3b51

Browse files
committed
add negative numbers to test and compare values
Please enter the commit message for your changes. Lines starting
1 parent 77a38e1 commit e6e3b51

File tree

2 files changed

+32
-4
lines changed

2 files changed

+32
-4
lines changed

tests/sample_data/big_int.otio

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,13 @@
2222
{
2323
"OTIO_SCHEMA": "Clip.1",
2424
"metadata": {
25-
"foobar": {
25+
"int_test": {
2626
"maxint32": 2147483647,
27+
"minint32": -2147483647,
2728
"toobig": 2147483648,
28-
"verybig": 3450100000
29+
"negtoobig": -2147483648,
30+
"verybig": 3450100000,
31+
"negverybig": -3450100000
2932
}
3033
},
3134
"name": "black",

tests/test_timeline.py

Lines changed: 27 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,33 @@ def test_metadata(self):
5454
def test_big_integers(self):
5555
result = otio.adapters.read_from_file(BIG_INT_TEST)
5656

57-
self.assertTrue(result.tracks[0][0].metadata["foobar"]["toobig"] > 0)
58-
self.assertTrue(result.tracks[0][0].metadata["foobar"]["verybig"] > 0)
57+
# positive integers
58+
self.assertEqual(
59+
result.tracks[0][0].metadata["int_test"]["maxint32"],
60+
2147483647
61+
)
62+
self.assertEqual(
63+
result.tracks[0][0].metadata["int_test"]["toobig"],
64+
2147483648
65+
)
66+
self.assertEqual(
67+
result.tracks[0][0].metadata["int_test"]["verybig"],
68+
3450100000
69+
)
70+
71+
# negative
72+
self.assertEqual(
73+
result.tracks[0][0].metadata["int_test"]["minint32"],
74+
-2147483647
75+
)
76+
self.assertEqual(
77+
result.tracks[0][0].metadata["int_test"]["negtoobig"],
78+
-2147483648
79+
)
80+
self.assertEqual(
81+
result.tracks[0][0].metadata["int_test"]["negverybig"],
82+
-3450100000
83+
)
5984

6085
def test_big_unsigned_integer_overflow(self):
6186
test_tl = otio.schema.Timeline()

0 commit comments

Comments
 (0)