Close Temporary file handles (#1363)

Signed-off-by: Mark Reid <[email protected]>

Author: markreidvfx

tests/test_otiod.py

@@ -102,7 +102,8 @@ def test_file_bundle_manifest(self):
             self.assertEqual(len(manifest[fname]), count)
 
     def test_round_trip(self):
-        tmp_path = tempfile.NamedTemporaryFile(suffix=".otiod").name
+        with tempfile.NamedTemporaryFile(suffix=".otiod") as bogusfile:
+            tmp_path = bogusfile.name
         otio.adapters.write_to_file(self.tl, tmp_path)
         self.assertTrue(os.path.exists(tmp_path))
 
@@ -132,7 +133,8 @@ def test_round_trip(self):
         self.assertJsonEqual(result, self.tl)
 
     def test_round_trip_all_missing_references(self):
-        tmp_path = tempfile.NamedTemporaryFile(suffix=".otiod").name
+        with tempfile.NamedTemporaryFile(suffix=".otiod") as bogusfile:
+            tmp_path = bogusfile.name
         otio.adapters.write_to_file(
             self.tl,
             tmp_path,
@@ -154,7 +156,8 @@ def test_round_trip_all_missing_references(self):
             )
 
     def test_round_trip_absolute_paths(self):
-        tmp_path = tempfile.NamedTemporaryFile(suffix=".otiod").name
+        with tempfile.NamedTemporaryFile(suffix=".otiod") as bogusfile:
+            tmp_path = bogusfile.name
         otio.adapters.write_to_file(self.tl, tmp_path)
 
         # ...but can be optionally told to generate absolute paths

tests/test_otioz.py

@@ -124,7 +124,8 @@ def test_colliding_basename(self):
         shutil.rmtree(tempdir)
 
     def test_round_trip(self):
-        tmp_path = tempfile.NamedTemporaryFile(suffix=".otioz").name
+        with tempfile.NamedTemporaryFile(suffix=".otioz") as bogusfile:
+            tmp_path = bogusfile.name
         otio.adapters.write_to_file(self.tl, tmp_path)
         self.assertTrue(os.path.exists(tmp_path))
 
@@ -155,7 +156,8 @@ def test_round_trip(self):
         self.assertJsonEqual(result, self.tl)
 
     def test_round_trip_with_extraction(self):
-        tmp_path = tempfile.NamedTemporaryFile(suffix=".otioz").name
+        with tempfile.NamedTemporaryFile(suffix=".otioz") as bogusfile:
+            tmp_path = bogusfile.name
         otio.adapters.write_to_file(self.tl, tmp_path)
         self.assertTrue(os.path.exists(tmp_path))
 
@@ -213,7 +215,8 @@ def test_round_trip_with_extraction(self):
         )
 
     def test_round_trip_with_extraction_no_media(self):
-        tmp_path = tempfile.NamedTemporaryFile(suffix=".otioz").name
+        with tempfile.NamedTemporaryFile(suffix=".otioz") as bogusfile:
+            tmp_path = bogusfile.name
         otio.adapters.write_to_file(
             self.tl,
             tmp_path,