Skip to content

Commit cd8db59

Browse files
apetrynetreinecke
authored andcommitted
Extracted CMX3600 adapter and related sample data and tests (#1487)
* Removed the cmx_3600 adapter * Removed sample data only used by the cmx_3600 adapter * Add "extract_adapters" to CI triggers * otioz test called for an edl we removed. Replaced with an otio file * Converted screening_example.edl to screening_example.otio and used it in tests * Removed other adapter suffixes from plugin tests as they belong to adapters soon to be extracted * Autogenerated docs for CMX3600 removed Signed-off-by: apetrynet <[email protected]> Signed-off-by: Eric Reinecke <[email protected]>
1 parent f15902c commit cd8db59

32 files changed

+466
-4489
lines changed

contrib/opentimelineio_contrib/adapters/tests/test_maya_sequencer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import opentimelineio as otio
1111

1212
SAMPLE_DATA_DIR = os.path.join(os.path.dirname(__file__), "sample_data")
13-
SCREENING_EXAMPLE_PATH = os.path.join(SAMPLE_DATA_DIR, "screening_example.edl")
13+
SCREENING_EXAMPLE_PATH = os.path.join(SAMPLE_DATA_DIR, "screening_example.otio")
1414
BASELINE_PATH = os.path.join(SAMPLE_DATA_DIR, "screening_example.ma")
1515
SETATTR_TO_CHECK = (".ef", ".sf", ".sn", ".se", ".ssf")
1616

docs/tutorials/otio-plugins.md

Lines changed: 0 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -33,56 +33,6 @@ Adapter plugins convert to and from OpenTimelineIO.
3333
[Tutorial on how to write an adapter](write-an-adapter).
3434

3535

36-
### cmx_3600
37-
38-
```
39-
OpenTimelineIO CMX 3600 EDL Adapter
40-
```
41-
42-
*source*: `opentimelineio/adapters/cmx_3600.py`
43-
44-
45-
*Supported Features (with arguments)*:
46-
47-
- read_from_string:
48-
```
49-
Reads a CMX Edit Decision List (EDL) from a string.
50-
Since EDLs don't contain metadata specifying the rate they are meant
51-
for, you may need to specify the rate parameter (default is 24).
52-
By default, read_from_string will throw an exception if it discovers
53-
invalid timecode in the EDL. For example, if a clip's record timecode
54-
overlaps with the previous cut. Since this is a common mistake in
55-
many EDLs, you can specify ignore_timecode_mismatch=True, which will
56-
supress these errors and attempt to guess at the correct record
57-
timecode based on the source timecode and adjacent cuts.
58-
For best results, you may wish to do something like this:
59-
60-
Example:
61-
>>> try:
62-
... timeline = otio.adapters.read_from_string("mymovie.edl", rate=30)
63-
... except EDLParseError:
64-
... print('Log a warning here')
65-
... try:
66-
... timeline = otio.adapters.read_from_string(
67-
... "mymovie.edl",
68-
... rate=30,
69-
... ignore_timecode_mismatch=True)
70-
... except EDLParseError:
71-
... print('Log an error here')
72-
```
73-
- input_str
74-
- rate
75-
- ignore_timecode_mismatch
76-
- write_to_string:
77-
- input_otio
78-
- rate
79-
- style
80-
- reelname_len
81-
82-
83-
84-
85-
8636
### fcp_xml
8737

8838
```

src/py-opentimelineio/opentimelineio/adapters/builtin_adapters.plugin_manifest.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,6 @@
2525
"filepath" : "otiod.py",
2626
"suffixes" : ["otiod"]
2727
},
28-
{
29-
"OTIO_SCHEMA" : "Adapter.1",
30-
"name" : "cmx_3600",
31-
"filepath" : "cmx_3600.py",
32-
"suffixes" : ["edl"]
33-
},
3428
{
3529
"OTIO_SCHEMA" : "Adapter.1",
3630
"name" : "svg",

0 commit comments

Comments
 (0)