clang notices that constexpr can't be used on a mutating function (#1242)

meshula · nporcino-pixar · jminor · commit 452003cb4c3f · 2022-05-02T16:45:45.000-07:00
* clang notices that constexpr can't be used on a mutating function

* Update src/opentime/rationalTime.h

Co-authored-by: Nick Porcino &lt;nporcino@pixar.com&gt;
diff --git a/src/opentime/rationalTime.h b/src/opentime/rationalTime.h
@@ -153,7 +153,7 @@ class RationalTime
 
     std::string to_time_string() const;
 
-    constexpr RationalTime const& operator+=(RationalTime other) noexcept
+   RationalTime const& operator+=(RationalTime other) noexcept
     {
         if (_rate < other._rate)
         {
@@ -167,7 +167,7 @@ class RationalTime
         return *this;
     }
 
-    constexpr RationalTime const& operator-=(RationalTime other) noexcept
+   RationalTime const& operator-=(RationalTime other) noexcept
     {
         if (_rate < other._rate)
         {

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ class RationalTime`
`153`	`153`
`154`	`154`	`std::string to_time_string() const;`
`155`	`155`
`156`		`- constexpr RationalTime const& operator+=(RationalTime other) noexcept`
	`156`	`+ RationalTime const& operator+=(RationalTime other) noexcept`
`157`	`157`	`{`
`158`	`158`	`if (_rate < other._rate)`
`159`	`159`	`{`
`@@ -167,7 +167,7 @@ class RationalTime`
`167`	`167`	`return *this;`
`168`	`168`	`}`
`169`	`169`
`170`		`- constexpr RationalTime const& operator-=(RationalTime other) noexcept`
	`170`	`+ RationalTime const& operator-=(RationalTime other) noexcept`
`171`	`171`	`{`
`172`	`172`	`if (_rate < other._rate)`
`173`	`173`	`{`